vrahane commented on a change in pull request #420: sys/console: fix console
compatibility
URL: https://github.com/apache/mynewt-core/pull/420#discussion_r127850134
##########
File path: sys/console/full/src/console.c
##########
@@ -473,10 +474,14 @@ console_handle_char(uint8_t byte)
case ESC:
esc_state |= ESC_ESC;
break;
- default:
- insert_char(&input->line[cur], byte, end);
- /* Falls through. */
case '\r':
Review comment:
/* Falls through. */ comment is needed here as GCC7 gives an error without
an explicit commented fallthrough.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
