mkiiskila commented on a change in pull request #448: [WIP DO NOT MERGE] PWM
high level API
URL: https://github.com/apache/mynewt-core/pull/448#discussion_r131003490
##########
File path: hw/bsp/nrf52dk/pkg.yml
##########
@@ -39,8 +39,8 @@ pkg.cflags:
- '-DPDM_ENABLED=0'
- '-DPERIPHERAL_RESOURCE_SHARING_ENABLED=1'
- '-DPWM0_ENABLED=1'
- - '-DPWM1_ENABLED=0'
- - '-DPWM2_ENABLED=0'
+ - '-DPWM1_ENABLED=1'
+ - '-DPWM2_ENABLED=1'
Review comment:
I wonder if we could make these SDK flags conditional, such that
PWMx_ENABLED would be set only if the matching os_dev for that PWM is enabled
with that BSP.
I.e. in hw/bsp/nrf52dk/pkg.yml, you would have:
pkg.cflags.PWM0_ENABLED: -DPWM0_ENABLED
and in this file you'd have pkg.cflags: -DPWM0_ENABLED.
It *should* work, as newt orders the cflags passed to command line, although
it might be a bit too hacky. I.e. depends on newt doing the cflag ordering.
Others might have comments regarding this approach?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
