mlaz commented on issue #763: [WIP - Do not merge] Integrate nrfx URL: https://github.com/apache/mynewt-core/pull/763#issuecomment-363623720 > Also this PR creates a new sysflag ADC that needs to be enabled in addition, plus ADC_0 for the 0 channel. Its more newty to simply check of the ADC_0 etc, for instance like the STM adc driver currently does @jacobrosenthal Agreed, I'll make it work like STM ADC driver. Probably the PWM macros should work this way as well for pwm_nrf52. > @mlaz Seems like you deleted the adc_test you had in here? What did you run on nrf52 that I can test on nrf51? I did because this app will probably only work with adc_nrf52, since the driver makes you use nordic structures namely nrf_saadc_channel_config_t. These test apps, imho, should be generic, i.e. the code should be able to run with whatever driver according to whatever syscfg macros the user sets. Just like pwm_test(which still needs some work in this direction) works with pwm_nrf52 and soft_pwm.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
