mkiiskila commented on a change in pull request #757: HW driver: drv2605l URL: https://github.com/apache/mynewt-core/pull/757#discussion_r166530384
########## File path: hw/drivers/drv2605/syscfg.yml ########## @@ -0,0 +1,67 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + +syscfg.defs: + DRV2605_CLI: + description: 'Enable shell support for the DRV2605' + value: 0 + DRV2605_LOG: + description: 'Enable DRV2605 logging' + value: 0 + DRV2605_STATS: + description: 'Enable DRV2605 statistics' + value: 0 + DRV2605_SHELL_ITF_TYPE: + description: 'DRV2605 interface type - I2C' + value: 1 + DRV2605_SHELL_ITF_NUM: + description: 'DRV2605 interface number' + value: 0 + DRV2605_SHELL_ITF_ADDR: + description: 'DRV2605 I2C Address' + value: 0x5A + + DRV2605_EN_PIN: + description: 'EN pin' + value: 3 Review comment: I probably would default this to be -1, and have people define it either in their target or BSP, depending on how they're wiring it. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
