vrahane commented on issue #718: MYNEWT-881 SensorAPI: LIS2DH12 set thresh cb fix URL: https://github.com/apache/mynewt-core/pull/718#issuecomment-365477855 @rymanluk I have addressed the comments and I do agree with your comments, I was a bit confused about the unset API since there are different ways of taking care of things but what I have done in the above commits should be good enough considering we have to enable/disable specific interrupts in the sensors registers if all the interrupts are not disabled. Hence, hal_gpio_irq_release() can only be called if all the thresholds are not valid. Hope I am making sense. Please go through the PR once again. Thank you.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
