andrzej-kaczmarek commented on a change in pull request #819: Feature/blecsc app: Cycling Speed and Cadence app URL: https://github.com/apache/mynewt-core/pull/819#discussion_r169005323
########## File path: net/nimble/host/services/gap/include/services/gap/ble_svc_gap.h ########## @@ -37,6 +37,8 @@ struct ble_hs_cfg; const char *ble_svc_gap_device_name(void); int ble_svc_gap_device_name_set(const char *name); +int ble_svc_gap_device_appearance(void); +int ble_svc_gap_device_appearance_set(const uint16_t appearance); Review comment: I'd actually make this a syscfg value (BLE_SVC_GAP_APPEARANCE) the reason for this is that appearance is read-only so it cannot (and should not) be changed in runtime. getter is ok though. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
