jacobrosenthal commented on a change in pull request #836: PWM add cycle 
interrupt handling to pwm_nrf52 driver
URL: https://github.com/apache/mynewt-core/pull/836#discussion_r170034144
 
 

 ##########
 File path: hw/drivers/pwm/pwm_nrf52/src/pwm_nrf52.c
 ##########
 @@ -177,9 +249,10 @@ nrf52_pwm_close(struct os_dev *odev)
 
     dev = (struct pwm_dev *) odev;
     inst_id = dev->pwm_instance_id;
+    assert(instances[inst_id].in_use);
 
     nrfx_pwm_uninit(&instances[inst_id].drv_instance);
-    instances[inst_id].playing = false;
+    cleanup_instance(inst_id);
 
 Review comment:
   I take it the assert is whats currently protecting us from a regressions 
from this recent commit?
   https://github.com/apache/mynewt-core/pull/821/files

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to