utzig commented on a change in pull request #140: newt - Repo dependencies
URL: https://github.com/apache/mynewt-newt/pull/140#discussion_r172923765
 
 

 ##########
 File path: newt/repo/repo.go
 ##########
 @@ -596,18 +499,18 @@ func (r *Repo) Sync(vers *Version, force bool) (bool, 
error) {
                msg := "Unexpected local branch for %s: \"%s\" != \"%s\""
                if force {
                        util.StatusMessage(util.VERBOSITY_DEFAULT,
-                               msg+"\n", r.rdesc.name, currBranch, branchName)
+                               msg+"\n", r.Name(), currBranch, branchName)
                } else {
-                       err = util.FmtNewtError(
-                               msg, r.rdesc.name, currBranch, branchName)
+                       err := util.FmtNewtError(
+                               msg, r.Name(), currBranch, branchName)
 
 Review comment:
   hmmmm, I thought the rule for short variable declaration was that at least 
one variable must be newly declared... but `err` is already declared above...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to