ccollins476ad commented on a change in pull request #140: newt - Repo
dependencies
URL: https://github.com/apache/mynewt-newt/pull/140#discussion_r172954972
##########
File path: newt/downloader/downloader.go
##########
@@ -667,8 +667,8 @@ func (ld *LocalDownloader) CurrentBranch(path string)
(string, error) {
}
func (ld *LocalDownloader) UpdateRepo(path string, branchName string) error {
- // Nothing to update in a local repo.
- return nil
+ os.RemoveAll(path)
Review comment:
It isn't ideal. Ideally, newt would detect changes by comparing all files
against the local repo's path.
The `local` repo type is just a debug feature, so I was a bit sloppy here.
I think a fix for this might be good as a separate PR. What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
