mlampert commented on a change in pull request #836: PWM add cycle interrupt
handling to pwm_nrf52 driver
URL: https://github.com/apache/mynewt-core/pull/836#discussion_r173568644
##########
File path: hw/drivers/pwm/include/pwm/pwm.h
##########
@@ -121,18 +134,43 @@ struct pwm_dev {
*
* pin - The pin to be assigned to this pwm channel.
* inverted - Whether this channel's output polarity is inverted or not.
- * data - A pointer do a driver specific parameter.
+ * n_cycles - The number of cycles for the channel to play. 0 for loop mode.
+ * interrupts - Whether interruptions are to be used or not.
+ * data - Driver specific data.
Review comment:
Would it make sense to add a comment here that if `interrupts == true` this
has to be a point to a `struct pwm_dev_interrupt_cfg` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
