andrzej-kaczmarek commented on issue #901: ble service: Device Information Service URL: https://github.com/apache/mynewt-core/pull/901#issuecomment-372063238 Few comments: - characteristics permissions should be configurable - for consistency, I'd make it the same way as configurable write permissions in GAP service so there's no need for separate enable and permissions syscfgs - also for consistency I'd use helpers to set values instead of using extern struct - there's no need for #error in case none of characteristics were enabled - this is explicitly allowed by spec - default value for characteristics with no value set should be an empty string - there are multiple consecutive empty lines in few places - use single empty line as separator As an addition, it may be useful to have default value for some/each characteristics in syscfg (same as e.g. Device Name in GAP) so there's no need to set all of them in application.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
