ncasaril closed pull request #1000: sys/config: Checking results on rc2 instead 
of rc
URL: https://github.com/apache/mynewt-core/pull/1000
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/sys/config/src/config.c b/sys/config/src/config.c
index 0793dc464a..b10bf0653a 100644
--- a/sys/config/src/config.c
+++ b/sys/config/src/config.c
@@ -295,7 +295,7 @@ conf_commit(char *name)
         SLIST_FOREACH(ch, &conf_handlers, ch_list) {
             if (ch->ch_commit) {
                 rc2 = ch->ch_commit();
-                if (!rc) {
+                if (!rc2) {
                     rc = rc2;
                 }
             }
diff --git a/sys/config/src/config_store.c b/sys/config/src/config_store.c
index 3e7d0842ff..c383a682dd 100644
--- a/sys/config/src/config_store.c
+++ b/sys/config/src/config_store.c
@@ -176,7 +176,7 @@ conf_save(void)
     SLIST_FOREACH(ch, &conf_handlers, ch_list) {
         if (ch->ch_export) {
             rc2 = ch->ch_export(conf_store_one, CONF_EXPORT_PERSIST);
-            if (!rc) {
+            if (!rc2) {
                 rc = rc2;
             }
         }


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to