ncasaril commented on issue #940: nrf52xxx_i2c: Fix to allow hal_i2c_clear_bus to read from input-buffer URL: https://github.com/apache/mynewt-core/pull/940#issuecomment-379506907 The only problem with moving the hal_gpio_read_in() to hal_gpio is that it will not be defined in the hal_gpio.h unless I change that as well. If this is only specific to the Nordic, and only really to when clearing the i2c bus, perhaps it's better to not change the hal_gpio, but rather just rename the function and keep it in hal_i2c. I've renamed the function and kept it in hal_i2c. See what you think about this @vrahane .
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
