ccollins476ad commented on a change in pull request #994: Add configuration 
documentation
URL: https://github.com/apache/mynewt-core/pull/994#discussion_r180230101
 
 

 ##########
 File path: sys/config/include/config/config.h
 ##########
 @@ -38,39 +40,131 @@ extern "C" {
 
 #define CONF_NMGR_OP           0
 
+/** @endcond */
+
 /**
  * Type of configuration value.
  */
-enum conf_type {
+typedef enum conf_type {
     CONF_NONE = 0,
     CONF_DIR,
+    /** 8-bit signed integer */
     CONF_INT8,
+    /** 16-bit signed integer */
     CONF_INT16,
+    /** 32-bit signed integer */
     CONF_INT32,
+    /** 64-bit signed integer */
     CONF_INT64,
+    /** String */
     CONF_STRING,
+    /** Bytes */
     CONF_BYTES,
+    /** Floating point */
     CONF_FLOAT,
+    /** Double precision */
     CONF_DOUBLE,
+    /** Boolean */
     CONF_BOOL,
-} __attribute__((__packed__));
+} __attribute__((__packed__)) conf_type_t;
 
 /**
  * Parameter to commit handler describing where data is going to.
  */
 enum conf_export_tgt {
-    CONF_EXPORT_PERSIST,        /* Value is to be persisted. */
-    CONF_EXPORT_SHOW            /* Value is to be displayed. */
+    /** Value is to be persisted */
+    CONF_EXPORT_PERSIST,
+    /** Value is to be display */
 
 Review comment:
   Looks like an `ed` was accidentally removed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to