wes3 commented on issue #1015: nrf52840 support for qspi flash
URL: https://github.com/apache/mynewt-core/pull/1015#issuecomment-381258918
   @kasjer I understand about the lack of sensible defaults. One way I have 
seen this done (and I am not saying this is good or bad) is that "nonsensical" 
values are assigned to these values by default. These nonsensical values are 
then checked in the code and if they are still nonsensical, meaning not 
overridden somewhere, the code fails to compile. I guess this could be done run 
time but generally it is done by the preprocessor. For example:
   #error "Must override qspi flash sector size"
   Or some such thing; I am sure you get the idea.

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

With regards,
Apache Git Services

Reply via email to