brolan-juul commented on a change in pull request #1024: lis2dw12: Support
sleep change event for notifications
URL: https://github.com/apache/mynewt-core/pull/1024#discussion_r181618201
##########
File path: hw/drivers/sensors/lis2dw12/src/lis2dw12.c
##########
@@ -2790,8 +2836,9 @@ lis2dw12_config(struct lis2dw12 *lis2dw12, struct
lis2dw12_cfg *cfg)
goto err;
}
- lis2dw12->cfg.stream_read_interrupt = cfg->stream_read_interrupt;
- lis2dw12->cfg.read_mode = cfg->read_mode;
+ lis2dw12->cfg.read_mode.int_cfg = cfg->read_mode.int_cfg;
+ lis2dw12->cfg.read_mode.int_num = cfg->read_mode.int_num;
+ lis2dw12->cfg.read_mode.mode = cfg->read_mode.mode;
lis2dw12->cfg.mask = cfg->mask;
Review comment:
Is the mask intended to encompass sensor_type_t & sensor_event_type_t?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
