andrzej-kaczmarek commented on a change in pull request #105: porting: Cleanup
and fix NPL
URL: https://github.com/apache/mynewt-nimble/pull/105#discussion_r190066317
##########
File path: porting/nimble/src/nimble_port.c
##########
@@ -44,14 +38,6 @@ nimble_port_init(void)
ble_hs_init();
- /* XXX These should be configurable somehow */
- ble_svc_gap_init();
Review comment:
it's mandatory for peripheral and central so should only be included if
needed. in Mynewt app needs to explicitly add dep to package for GAP (and also
GATT) service to be included so it works pretty much the same here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
