rymanluk commented on a change in pull request #108: nimble/ll: Vendor error
event on assert
URL: https://github.com/apache/mynewt-nimble/pull/108#discussion_r190531050
##########
File path: nimble/controller/include/controller/ble_ll.h
##########
@@ -34,6 +35,14 @@ extern "C" {
#error 32.768kHz clock required
#endif
+#define BLE_LL_ASSERT(cond) \
+ if (!(cond)) { \
+ ble_ll_hci_ev_send_vendor_err(__FILE__, __LINE__); \
+ if (hal_debugger_connected()) { \
+ assert(0);\
Review comment:
well, actually I will remove hal_debugger_connected - each architecture
will do on assert what is needed.
update: ahh no, having assert(0) after sending event will cause that event
will not reach host basically. We can do while(1) after sending it and
controller will be reset by watchdog. But when debugging we would like to break
in this exact place.
assert is there as we have different architecture to support.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
