wes3 commented on issue #1093: timeout/tick / int32_t vs uint32_t URL: https://github.com/apache/mynewt-core/issues/1093#issuecomment-392872527 @sdalu Yes I can. Of course, this is just my opinion. Adding a definition that means the same thing as something else is confusing to me. Why are there two defines that mean the same thing? You would then have some people using os_ticks_t and some using os_time_t. That would add to the confusion, don't you think? I am not sure if this was suggested, but changing the name at this point is simply not an option. Do not get me wrong, I think os_ticks_t might be a better name than os_time_t but pretty much every RTOS I have come in contact with has some concept of an "os time tick" that is not necessarily in any particular unit of time; you configure it for your platform/system. I have seen "os time" used in a number of different OS's so I do not think mynewt is far from the norm here. I think your comment to chris makes alot of sense btw. I am not sure how well this is documented and showing some common coding pitfalls i.e. if (time < os_time_get()) would be super helpful.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
