mlaz commented on issue #1169: nrf52_pwm: catch NRFX_PWM_EVT_STOPPED events URL: https://github.com/apache/mynewt-core/pull/1169#issuecomment-395218328 > Should nrf52_pwm_close just call nrf52_pwm_disable instead of calling > > ``` > if (!instances[inst_id].playing) { > nrfx_pwm_uninit(&instances[inst_id].drv_instance); > } > > ``` > We can do that. > Will nrfx_pwm_stop ever be called if you nrf52_pwm_close without nrf52_pwm_disable first? Right now it may not be, in fact it doesn't need to be stopped before it is disabled. However I find your suggestion to make sense. Commit updated.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
