jacobrosenthal commented on a change in pull request #1169: nrf52_pwm: catch
NRFX_PWM_EVT_STOPPED events
URL: https://github.com/apache/mynewt-core/pull/1169#discussion_r193600099
##########
File path: hw/drivers/pwm/pwm_nrf52/src/pwm_nrf52.c
##########
@@ -336,7 +342,7 @@ nrf52_pwm_close(struct os_dev *odev)
}
if (!instances[inst_id].playing) {
- nrfx_pwm_uninit(&instances[inst_id].drv_instance);
+ nrf52_pwm_disable(dev);
Review comment:
Again, whether it should call nrf52_pwm_disable from nrf52_pwm_close I dont
have an opinion, it just seems like were sharing code, but doing things
differently in both... which seems odd
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
