utzig commented on issue #1297: Fix some issues with the L1/L0 flash driver
URL: https://github.com/apache/mynewt-core/pull/1297#issuecomment-408472109
 
 
   @mkiiskila Ok, call me an ass but I didn't even consider to use `#ifdefs` 
with `MYNEWT_VAL(MCU_FLASH_MIN_WRITE_SIZE)`. It no doubt beats speed of using 
division (but generates same code size). Now I'm wondering why only the native 
flash driver makes `.hf_align = MYNEWT_VAL(MCU_FLASH_MIN_WRITE_SIZE)` since 
this seems like a duplication for every BSP/MCU!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to