ccollins476ad commented on a change in pull request #1341: sys/console: add
support for silencing output from the console
URL: https://github.com/apache/mynewt-core/pull/1341#discussion_r211435307
##########
File path: sys/console/full/src/ble_monitor_console.c
##########
@@ -27,6 +27,10 @@
int
console_out(int c)
{
+ if (g_silence_console) {
+ return 0;
Review comment:
It might not make a difference in practice, but the `console_out` functions
should probably return `c` here instead of 0. It appears the semantics is:
return `c` on success; return`EOF` on failure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
