ccollins476ad commented on a change in pull request #1336: Add flash-id
parameter to flash cli command
URL: https://github.com/apache/mynewt-core/pull/1336#discussion_r211440777
##########
File path: test/flash_test/src/flash_test/flash_test.c
##########
@@ -41,69 +41,99 @@ flash_cli_cmd(int argc, char **argv)
uint32_t sz = 1;
int sec_cnt;
int i;
+ int devid;
int soff;
char *eptr;
char tmp_buf[8];
char pr_str[80];
- hf = hal_bsp_flash_dev(0);
- if (!hf) {
- console_printf("No flash device present\n");
+ if (argc > 1 && (!strcmp(argv[1], "?") || !strcmp(argv[1], "help"))) {
+ console_printf("Commands Available\n");
+ console_printf("flash <flash-id> -- dumps sector map \n");
Review comment:
Should this be `[flash-id]` (i.e., this argument is optional)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
