ccollins476ad commented on issue #201: Allow setting value to reference other setting URL: https://github.com/apache/mynewt-newt/pull/201#issuecomment-414856063 I like the feature, but I have two comments: 1. I am not sure how I feel about `@` as a prefix. Since this is already used to designate a repo name, I worry this could be confusing for users. I wonder if it would be clearer if the notation were: `MYNEWT_VAL(setting_name)`. I am really not sure, though... if you think `@` is fine then it is probably OK. 2. Would you mind renaming `ResolveValues()` to something less generic? Maybe `ResolveReferences()`?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
