kasjer commented on a change in pull request #1507: [RFC] Add generic serial bus driver URL: https://github.com/apache/mynewt-core/pull/1507#discussion_r233064568
########## File path: hw/hal/include/hal/hal_spi.h ########## @@ -60,6 +60,14 @@ extern "C" { /* Prototype for tx/rx callback */ typedef void (*hal_spi_txrx_cb)(void *arg, int len); +/** SPI controller hardware settings */ +struct hal_spi_hw_settings { + uint8_t pin_sck; Review comment: in other places pins are ints ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services