andrzej-kaczmarek commented on issue #256: porting: Check FreeRTOS timer status 
before stopping it
URL: https://github.com/apache/mynewt-nimble/pull/256#issuecomment-448536904
 
 
   @yang325 @dhrishi I think I explained this already, but let me clarify once 
more: in my opinion there is no issue in FreeRTOS NPL which assumes that 
callout which we try to stop was previously initialized (otherwise we need to 
modify every single NPL API to make checks if objects are valid to be 
consistent here). This is apparently not the case due to change made in 
mentioned commit so proper solution is to rework that fix so it will not try to 
stop callout before it was initialized. Simply removing that code is not a 
proper solution since it will most likely cause new regression.
   
   I do not know what is the proper fix in the code here since I did not have 
time to analyze this. Feel free to do this and provide fix which resolves 
mentioned issue and will not cause regression. Also, in case you disagree with 
my analysis please simply provide a reasonable arguments and I'll reconsider 
the workaround for sure.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to