dhrishi commented on issue #256: porting: Check FreeRTOS timer status before 
stopping it
URL: https://github.com/apache/mynewt-nimble/pull/256#issuecomment-448555932
 
 
   
   @andrzej-kaczmarek Thanks for your response. 
   
   >  proper solution is to rework that fix so it will not try to stop callout 
before it was initialized.
   
   I agree to this partially. I mean, this will help us fix this issue, no 
doubt. But this will be specific to this scenario only. If tomorrow someone 
calls these APIs in sequence from somewhere else then that will have to be 
fixed again.
   
   May be that is the same reason why implementation of `ble_npl_callout_stop` 
in NPL for Linux has a check to see if it was inited before stopping it. So, I 
think the change in this pull request should be good. 
   Although, the check can be made through an API (just like the Linux 
implementation does), which can be used from other places going ahead, if 
required.
   
   Let me know if you feel this is not the right approach or if I am missing 
something.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to