nvlsianpu commented on a change in pull request #14: Move platform #ifdefery to <nffs/os.h> URL: https://github.com/apache/mynewt-nffs/pull/14#discussion_r242882606
########## File path: include/nffs/os.h ########## @@ -21,9 +21,29 @@ #define H_OS_ #include <stdint.h> -#if __ZEPHYR__ + +#if MYNEWT + +#include "fs/fs.h" +#include "fs/fs_if.h" +struct fs_ops nffs_ops; Review comment: So now this instance is used everywhere https://github.com/apache/mynewt-nffs/blob/5e51a48f97366ec2ebb9a213274b11688022f1a0/test/src/nffs_os_mynewt.c#L322 Previously it was different variable in each file - doesn't this break something? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
