kasjer commented on a change in pull request #1629: hw/mcu/nrf52: Add option to
use GPIOTE port event
URL: https://github.com/apache/mynewt-core/pull/1629#discussion_r254039393
##########
File path: hw/mcu/nordic/nrf52xxx/src/hal_gpio.c
##########
@@ -394,7 +394,7 @@ hal_gpio_irq_init(int pin, hal_gpio_irq_handler_t handler,
void *arg,
hal_gpio_init_in(pin, pull);
#if MYNEWT_VAL(MCU_GPIO_USE_PORT_EVENT)
- conf = 0;
+ (void)conf;
Review comment:
It could be possible to use if instead of #if then we would have syntax
checking for 0 and 1 at once and possibly no need to (void) unused variables.
Not that I object to what has been done, just a thought for the future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
