utzig commented on a change in pull request #266: `newt target dump` command URL: https://github.com/apache/mynewt-newt/pull/266#discussion_r256365593
########## File path: newt/parse/expr.go ########## @@ -0,0 +1,75 @@ +package parse + +// ExprSet is a set of expressions. The map value is the expression itself; +// the key is the string representation of the expression, obtained via +// `Node#String()`. This is implemented as a map in this way to prevent +// duplicate expreessions. Review comment: typo `expressions` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
