ccollins476ad commented on issue #1678: test/testutil: Simplify API URL: https://github.com/apache/mynewt-core/pull/1678#issuecomment-470571515 Thanks, @mkiiskila. No, not all unittest packages need to change. The `TEST_CASE` macro should continue to work as before, so those `microbuilder` unit tests should continue to work (and will always work). HOWEVER, this PR does make some compatibility breaking changes to the testutil configuration API. I don't believe those microbuilder tests use any parts of the discarded API, but other people's tests might. After thinking about it some more, I don't think it is acceptable to break this API without any heads up. I will update this PR to preserve backwards compatibility, but will mark deprecated functions with the `deprecated` gcc attribute. The fact that you were able to find some test code so quickly tells me that there must be more testutil users than I guessed! So I will mark this as do-not-merge until I restore backwards compatibility. Thanks for the heads up!
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
