rymanluk commented on a change in pull request #365: controller: fix missing
critical sections for ble_ll_xcvr_rfclk_x calls
URL: https://github.com/apache/mynewt-nimble/pull/365#discussion_r263568141
##########
File path: nimble/controller/src/ble_ll_xcvr.c
##########
@@ -102,7 +102,10 @@ void
ble_ll_xcvr_rfclk_timer_exp(void *arg)
{
if (g_ble_ll_data.ll_rfclk_state == BLE_RFCLK_STATE_OFF) {
+ os_sr_t sr;
Review comment:
'os_sr_t sr' shall be on top of the function according to coding guide
This is timer callback function which in nimble is called when interrupts
disabled, could you do the same for RIOT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
