This is an automated email from the ASF dual-hosted git repository.
jerzy pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mynewt-core.git
The following commit(s) were added to refs/heads/master by this push:
new 0211fe7 sensors: Fix printf-style formatting in logs
0211fe7 is described below
commit 0211fe7d2d69e771b6883a9a45538f098b0942e8
Author: Jerzy Kasenberg <[email protected]>
AuthorDate: Thu Sep 26 16:04:12 2019 +0200
sensors: Fix printf-style formatting in logs
Some drivers had incompatible with format specifier argument
list in logging statements.
Those were found by static code analyzing tool.
---
hw/drivers/sensors/bma2xx/src/bma2xx.c | 2 +-
hw/drivers/sensors/icp101xx/src/icp101xx.c | 2 +-
hw/drivers/sensors/lis2ds12/src/lis2ds12.c | 2 +-
hw/drivers/sensors/lis2dw12/src/lis2dw12.c | 2 +-
hw/drivers/sensors/lsm6dso/src/lsm6dso.c | 2 +-
5 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/hw/drivers/sensors/bma2xx/src/bma2xx.c
b/hw/drivers/sensors/bma2xx/src/bma2xx.c
index 7d8e8cc..0f8a4ac 100644
--- a/hw/drivers/sensors/bma2xx/src/bma2xx.c
+++ b/hw/drivers/sensors/bma2xx/src/bma2xx.c
@@ -229,7 +229,7 @@ spi_writereg(struct sensor_itf * itf, uint8_t addr, uint8_t
payload,
rc = hal_spi_tx_val(itf->si_num, payload);
if (rc == 0xFFFF) {
rc = SYS_EINVAL;
- BMA2XX_LOG_ERROR("SPI_%u write failed addr:0x%02X:0x%02X\n",
+ BMA2XX_LOG_ERROR("SPI_%u write failed addr:0x%02X\n",
itf->si_num, addr);
goto err;
}
diff --git a/hw/drivers/sensors/icp101xx/src/icp101xx.c
b/hw/drivers/sensors/icp101xx/src/icp101xx.c
index aabac13..e47971e 100644
--- a/hw/drivers/sensors/icp101xx/src/icp101xx.c
+++ b/hw/drivers/sensors/icp101xx/src/icp101xx.c
@@ -275,7 +275,7 @@ icp101xx_read(struct sensor_itf *itf, uint8_t * buf,
uint32_t len)
rc = i2cn_master_read(itf->si_num, &data_struct, OS_TICKS_PER_SEC / 10,
1, MYNEWT_VAL(ICP101XX_I2C_RETRIES));
if (rc) {
- ICP101XX_LOG_ERROR("Failed to read %d bytes from 0x%x\n",
+ ICP101XX_LOG_ERROR("Failed to read %u bytes from 0x%x\n", len,
data_struct.address);
}
diff --git a/hw/drivers/sensors/lis2ds12/src/lis2ds12.c
b/hw/drivers/sensors/lis2ds12/src/lis2ds12.c
index 5284069..af07684 100644
--- a/hw/drivers/sensors/lis2ds12/src/lis2ds12.c
+++ b/hw/drivers/sensors/lis2ds12/src/lis2ds12.c
@@ -195,7 +195,7 @@ lis2ds12_spi_writelen(struct sensor_itf *itf, uint8_t addr,
uint8_t *payload,
rc = hal_spi_tx_val(itf->si_num, payload[i]);
if (rc == 0xFFFF) {
rc = SYS_EINVAL;
- LIS2DS12_LOG_ERROR("SPI_%u write failed addr:0x%02X:0x%02X\n",
+ LIS2DS12_LOG_ERROR("SPI_%u write failed addr:0x%02X\n",
itf->si_num, addr);
STATS_INC(g_lis2ds12stats, write_errors);
goto err;
diff --git a/hw/drivers/sensors/lis2dw12/src/lis2dw12.c
b/hw/drivers/sensors/lis2dw12/src/lis2dw12.c
index c07eaab..a7dfc73 100644
--- a/hw/drivers/sensors/lis2dw12/src/lis2dw12.c
+++ b/hw/drivers/sensors/lis2dw12/src/lis2dw12.c
@@ -296,7 +296,7 @@ lis2dw12_spi_writelen(struct sensor_itf *itf, uint8_t addr,
uint8_t *payload,
rc = hal_spi_tx_val(itf->si_num, payload[i]);
if (rc == 0xFFFF) {
rc = SYS_EINVAL;
- LIS2DW12_LOG_ERROR("SPI_%u write failed addr:0x%02X:0x%02X\n",
+ LIS2DW12_LOG_ERROR("SPI_%u write failed addr:0x%02X\n",
itf->si_num, addr);
STATS_INC(g_lis2dw12stats, write_errors);
goto err;
diff --git a/hw/drivers/sensors/lsm6dso/src/lsm6dso.c
b/hw/drivers/sensors/lsm6dso/src/lsm6dso.c
index 6132c20..9051193 100644
--- a/hw/drivers/sensors/lsm6dso/src/lsm6dso.c
+++ b/hw/drivers/sensors/lsm6dso/src/lsm6dso.c
@@ -2095,7 +2095,7 @@ int lsm6dso_get_ag_data(struct sensor_itf *itf,
sensor_type_t type, void *data,
sensitivity = cfg->acc_sensitivity;
break;
default:
- LSM6DSO_LOG_ERROR("Invalid sensor type: %d\n", type);
+ LSM6DSO_LOG_ERROR("Invalid sensor type: %d\n", (int)type);
return SYS_EINVAL;
}
