This is an automated email from the ASF dual-hosted git repository.

jerzy pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mynewt-core.git


The following commit(s) were added to refs/heads/master by this push:
     new 4dead28  sensors/lsm6dso: Fix control flow error in lsm6dso_spi_fixup
4dead28 is described below

commit 4dead289b7cc93fdbed5f4d3d13107f8ab5f65c7
Author: Jerzy Kasenberg <[email protected]>
AuthorDate: Fri Sep 27 09:40:55 2019 +0200

    sensors/lsm6dso: Fix control flow error in lsm6dso_spi_fixup
    
    Two curly braces were missing resulting in dead code.
    Final
     return hal_gpio_init_out(sensor->s_itf.si_cs_pin, 1);
    would never be called, which could be a problem.
---
 hw/drivers/sensors/lsm6dso/src/lsm6dso.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/hw/drivers/sensors/lsm6dso/src/lsm6dso.c 
b/hw/drivers/sensors/lsm6dso/src/lsm6dso.c
index 9051193..6616a03 100644
--- a/hw/drivers/sensors/lsm6dso/src/lsm6dso.c
+++ b/hw/drivers/sensors/lsm6dso/src/lsm6dso.c
@@ -515,8 +515,9 @@ static int lsm6dso_spi_fixup(struct sensor *sensor, struct 
sensor_itf *itf,
         rc = hal_spi_enable(sensor->s_itf.si_num);
         if (rc) {
             return rc;
+        }
 
-        if (init)
+        if (init) {
             return hal_gpio_init_out(sensor->s_itf.si_cs_pin, 1);
         }
     }

Reply via email to