mkiiskila commented on a change in pull request #27: Update mynewt port of mcumgr and various fixes URL: https://github.com/apache/mynewt-mcumgr/pull/27#discussion_r329963233
########## File path: cmd/img_mgmt/pkg.yml ########## @@ -24,7 +24,13 @@ pkg.homepage: "http://mynewt.apache.org/"; pkg.keywords: pkg.deps: + - '@apache-mynewt-mcumgr/cmd/img_mgmt/port/mynewt' - '@apache-mynewt-core/boot/split' - '@apache-mynewt-core/encoding/base64' - '@apache-mynewt-core/sys/flash_map' - - '@mynewt-mcumgr/mgmt' + - '@apache-mynewt-mcumgr/mgmt' + - '@apache-mynewt-mcumgr/cborattr' + - '@apache-mynewt-mcumgr/util' + +IMG_MGMT_LAZY_ERASE.cflags: Review comment: The conditional cflag name is wrong. Also, I assume this is unnecessary because of same #define in img_mgmt_config.h. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
