ccollins476ad commented on a change in pull request #335: Run custom commands
at build time
URL: https://github.com/apache/mynewt-newt/pull/335#discussion_r330645214
##########
File path: newt/resolve/resolve.go
##########
@@ -987,6 +994,22 @@ func (r *Resolver) resolveDepsAndCfg() error {
r.sysinitCfg = sysinit.Read(lpkgs, &r.cfg)
r.sysdownCfg = sysdown.Read(lpkgs, &r.cfg)
+ r.preBuildCmdCfg = extcmd.Read("pre_build_cmds", lpkgs, &r.cfg,
+ func(lpkg *pkg.LocalPackage,
+ settings map[string]string) map[string]string {
+ return lpkg.PreBuildCmds(settings)
+ })
+ r.preLinkCmdCfg = extcmd.Read("pre_link_cmds", lpkgs, &r.cfg,
+ func(lpkg *pkg.LocalPackage,
+ settings map[string]string) map[string]string {
+ return lpkg.PreLinkCmds(settings)
+ })
+ r.postBuildCmdCfg = extcmd.Read("post_build_cmds", lpkgs, &r.cfg,
Review comment:
Thanks @mkiiskila. For some reason I have a preference for `post_build`,
but I agree there is some ambiguity there, so I did the right thing and renamed
it to `post_link` :).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
