wes3 commented on a change in pull request #2024: hw/mcu/dialog: Add helper to enable/disable AMBA clocks URL: https://github.com/apache/mynewt-core/pull/2024#discussion_r330702534
########## File path: hw/mcu/dialog/da1469x/include/mcu/da1469x_hal.h ########## @@ -21,6 +21,7 @@ #define __MCU_DA1469X_HAL_H_ #include <assert.h> +#include "mcu/cmsis_nvic.h" Review comment: I guess you can say it is unrelated. Looks like cmsis_nvic.h brings in mcu.h which is needed for files that include da1469x_hal.h. I will change it to mcu.h; did not think this warranted a whole new PR. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
