mlaz commented on a change in pull request #1917: Use SMP/OMP/MCUmgr, remove 
newtmgr and change OICMGR to use OMP 
URL: https://github.com/apache/mynewt-core/pull/1917#discussion_r331237736
 
 

 ##########
 File path: mgmt/imgmgr/include/imgmgr/imgmgr.h
 ##########
 @@ -133,16 +145,31 @@ imgr_get_current_hash(uint8_t *hash, uint16_t hashlen);
  */
 void imgr_set_upload_cb(imgr_upload_fn *cb, void *arg);
 
-uint8_t imgmgr_state_flags(int query_slot);
-int imgmgr_state_slot_in_use(int slot);
-int imgmgr_state_set_pending(int slot, int permanent);
-int imgmgr_state_confirm(void);
-int imgmgr_find_best_area_id(void);
-void imgmgr_register_callbacks(const imgmgr_dfu_callbacks_t *cb_struct);
+/** @brief Generic callback function for events */
+typedef void (*imgmgr_dfu_cb)(void);
+
+/** Callback function pointers */
+typedef struct
+{
 
 Review comment:
   Fixed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to