vrahane commented on a change in pull request #2029: Added different scalars for ildo and for vbus/vled. URL: https://github.com/apache/mynewt-core/pull/2029#discussion_r332154580
########## File path: hw/drivers/adc/gpadc_da1469x/src/gpadc_da1469x.c ########## @@ -30,6 +30,10 @@ static struct da1469x_gpadc_dev *da1469x_gpadc_dev; +// 1/0.180265 * 1024 = 5680, 1/0.06907 * 1024 = 14825, 1/0.065067 * 1024 = 15737 +// 1/0.068603 * 1024 = 14926, 1/0.066215 * 1024 = 15464, 1/0.170288 * 1024 = 6013 Review comment: Can you please use C style comments instead of C++ style comments as per our coding style doc. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
