vrahane commented on a change in pull request #1917: Use SMP/OMP/MCUmgr, remove 
newtmgr and change OICMGR to use OMP 
URL: https://github.com/apache/mynewt-core/pull/1917#discussion_r332300560
 
 

 ##########
 File path: mgmt/smp/transport/smp_uart/src/smp_uart.c
 ##########
 @@ -23,47 +23,47 @@
 #include <bsp/bsp.h>
 
 #include <mgmt/mgmt.h>
-#include <newtmgr/newtmgr.h>
+#include <smp/smp.h>
 #include <uart/uart.h>
 
 #include <crc/crc16.h>
 #include <base64/base64.h>
 
 /**
- * \addtogroup Newtmgr Newtmgr
+ * \addtogroup SMP SMP
  * @{
  */
 
 #define SHELL_NLIP_PKT          0x0609
 #define SHELL_NLIP_DATA         0x0414
 
 #define NUS_EV_TO_STATE(ptr)                                            \
-    (struct nmgr_uart_state *)((uint8_t *)ptr -                         \
-      (int)&(((struct nmgr_uart_state *)0)->nus_cb_ev))
-
-struct nmgr_uart_state {
-    struct nmgr_transport nus_transport; /* keep first in struct */
-    struct os_event nus_cb_ev;
-    struct uart_dev *nus_dev;
-    struct os_mbuf *nus_tx;
-    int nus_tx_off;
-    struct os_mbuf_pkthdr *nus_rx_pkt;
-    struct os_mbuf_pkthdr *nus_rx_q;
-    struct os_mbuf_pkthdr *nus_rx;
+    (struct smp_uart_state *)((uint8_t *)ptr -                         \
+      (int)&(((struct smp_uart_state *)0)->sus_cb_ev))
+
+struct smp_uart_state {
+    struct smp_transport sus_transport; /* keep first in struct */
 
 Review comment:
   `smp.h` has the pseudo definition for it which is included in this source 
file.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to