utzig commented on issue #2017: P-NUCLEO-WB55 URL: https://github.com/apache/mynewt-core/pull/2017#issuecomment-539989367 @kasjer Could you take a look at this again, I think most review issues were tackled, apart from the `int` vs `unsigned` for I2c pins and flash suggestions (`FLASH_PAGE_SIZE` and removing `_` prefix). I am not sure what your suggestion is for the first one, but the issue spans across families so I think it would makes more sense to do it in another PR that covers them all. For the flash suggestions, I agree, but would rather send a new PR that changes it on every family. Is that OK?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
