ccollins476ad commented on a change in pull request #340: newt upgrade: Fix 
Repo Commit Checkout
URL: https://github.com/apache/mynewt-newt/pull/340#discussion_r334289782
 
 

 ##########
 File path: newt/install/install.go
 ##########
 @@ -647,17 +647,29 @@ func (inst *Installer) calcVersionMap(candidates 
[]*repo.Repo) (
        }
 
        // If project.yml specified any specific git commits, ensure we get 
them.
 
 Review comment:
   This comment could be updated to indicate that we are checking all repo 
dependencies (not just those from `project.yml`).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to