andrzej-kaczmarek commented on a change in pull request #1993: OTP drivers and scripts URL: https://github.com/apache/mynewt-core/pull/1993#discussion_r335327324
########## File path: hw/mcu/dialog/da14699/include/mcu/mcu.h ########## @@ -128,6 +128,9 @@ void mcu_gpio_exit_sleep(void); #define MCU_MEM_SYSRAM_START_ADDRESS (0x20000000) #define MCU_MEM_SYSRAM_END_ADDRESS (0x20080000) +#define OTPM_BASE 0x10080000UL +#define OTPM_SIZE 0x4096 Review comment: please add `MCU_` prefix to be consistent with other symbols in this file also should be 4096 instead of 0x4096 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
