rymanluk commented on a change in pull request #613: couple host scan fixes
URL: https://github.com/apache/mynewt-nimble/pull/613#discussion_r335920822
##########
File path: nimble/host/src/ble_gap.c
##########
@@ -4030,6 +4030,12 @@ ble_gap_disc(uint8_t own_addr_type, int32_t duration_ms,
p.passive = disc_params->passive;
p.window = disc_params->window;
+ if (duration_ms == BLE_HS_FOREVER) {
+ duration_ms = 0;
+ } else if (duration_ms == 0) {
Review comment:
behavior on duration_ms == 0 is not specified in the API, however indeed it
worked like that in legacy scan.
Would be worth to add it there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
