mkiiskila commented on a change in pull request #2052: FCB Rotate Notification
URL: https://github.com/apache/mynewt-core/pull/2052#discussion_r335926850
##########
File path: fs/fcb/src/fcb_getnext.c
##########
@@ -124,3 +166,18 @@ fcb_getnext(struct fcb *fcb, struct fcb_entry *loc)
return rc;
}
+
+int
+fcb_getnext_sector(struct fcb *fcb, struct fcb_entry *loc)
Review comment:
I don't see the need for fcb_getnext_nolock_sector() and
fcb_getnext_sector() routines. You get this kind of functionality by comparing
results from subsequent calls to fcb_getnext(), by checking if you've moved to
a different flash area using fe_area ptr value of passed/returned fcb_entry.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
