rymanluk commented on a change in pull request #639: nimble/ll: Fix extended
scanner data fragmentation issues
URL: https://github.com/apache/mynewt-nimble/pull/639#discussion_r343944210
##########
File path: nimble/controller/src/ble_ll_scan.c
##########
@@ -1205,11 +1204,20 @@ ble_ll_scan_aux_data_unref(struct ble_ll_aux_data
*aux_data)
ble_ll_trace_u32x2(BLE_LL_TRACE_ID_AUX_UNREF, (uint32_t) aux_data,
aux_data->ref_cnt);
if (aux_data->ref_cnt == 0) {
- /* Below assert is to detect missing complete or truncated event in
case of chaining */
- BLE_LL_ASSERT(!((BLE_LL_AUX_CHECK_FLAG(aux_data, BLE_LL_AUX_CHAIN_BIT)
&&
- BLE_LL_AUX_CHECK_FLAG(aux_data,
BLE_LL_SENT_EVENT_TO_HOST)) &&
- !(BLE_LL_AUX_CHECK_FLAG(aux_data,
BLE_LL_AUX_TRUNCATED_SENT) ||
- !BLE_LL_AUX_CHECK_FLAG(aux_data,
BLE_LL_AUX_INCOMPLETE_BIT))));
+ /*
+ * Some validation to make sure that we completed scan properly:
+ * - we either did not send any report or sent completed/truncated
+ * - we only sent one of completed/truncated
+ * - in case of error, we wither did not send anything or sent
truncated
Review comment:
either?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
