utzig commented on a change in pull request #2130: Remove restriction in syscfg
to define bitbang RX pin
URL: https://github.com/apache/mynewt-core/pull/2130#discussion_r357233149
##########
File path:
hw/mcu/stm/stm32l1xx/src/ext/Drivers/STM32L1xx_HAL_Driver/Src/stm32l1xx_hal_spi.c
##########
@@ -171,6 +171,7 @@ static HAL_StatusTypeDef SPI_WaitOnFlagUntilTimeout(struct
__SPI_HandleTypeDef *
* @{
*/
+#if 0 /* Fully defined in stm32l1xx_hal_spi_ex.c */
Review comment:
> I don't see why that is 'better' as a solution than fixing it in the
STM32L1xx driver source
Because when the SDK is updated to a newer version the maintainer will have
to be extra careful to not overwrite local changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
