nkaje commented on a change in pull request #2131: da1469x: Add Encrypted Flash 
Driver
URL: https://github.com/apache/mynewt-core/pull/2131#discussion_r357842514
 
 

 ##########
 File path: hw/drivers/flash/enc_flash/include/enc_flash/enc_flash.h
 ##########
 @@ -31,6 +31,7 @@ extern "C" {
 struct enc_flash_dev {
     struct hal_flash efd_hal;
     const struct hal_flash *efd_hwdev; /* pointer to underlying hw dev */
+    struct os_sem ef_sem;
 
 Review comment:
   Moving it the semaphore to eflash_da1469x_dev structure so that it's in the 
lowest layer. It will be accessed by the encryption driver for dialog

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to