ccollins476ad commented on a change in pull request #2157: sys/log: Remove 
support for LOG_VERSION 2
URL: https://github.com/apache/mynewt-core/pull/2157#discussion_r367176578
 
 

 ##########
 File path: sys/log/full/pkg.yml
 ##########
 @@ -30,20 +30,18 @@ pkg.deps:
     - "@apache-mynewt-core/sys/log/common"
     - "@apache-mynewt-core/util/cbmem"
 
-pkg.deps.'LOG_CLI && LOG_VERSION > 2':
-    - "@apache-mynewt-core/sys/log/util/log_cbor_reader"
-
 pkg.deps.LOG_FCB:
     - "@apache-mynewt-core/hw/hal"
     - "@apache-mynewt-core/fs/fcb"
 pkg.deps.LOG_FCB2:
     - "@apache-mynewt-core/fs/fcb2"
 pkg.deps.LOG_CLI:
+    - "@apache-mynewt-core/sys/log/util/log_cbor_reader"
 
 Review comment:
   Was this addition intentional?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to